[PATCH] D96371: [lit] Add --ignore-fail

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 02:04:01 PST 2021


jhenderson added a comment.

In D96371#2556413 <https://reviews.llvm.org/D96371#2556413>, @thopre wrote:

> I'm still not sure, I think a failure is a powerful motivator to fix something but patch LGTM otherwise. @jhenderson what do you think?

Sorry, I'm a little bit busy with other reviews, so haven't had a chance to dig into this properly yet.

If I follow what you're saying correctly, rather than check-all executing lit in a single run across multiple directories, in some cases, it is spawning a new lit process to run some test subset. Is that right? If so, I wonder if there's a better solution of getting check-all to actually run all the tests as one big test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96371/new/

https://reviews.llvm.org/D96371



More information about the llvm-commits mailing list