[PATCH] D96505: [RISCV] Convert VSLIDE(UP|DOWN) nodes to "VL" versions (NFC)

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 01:57:13 PST 2021


frasercrmck marked an inline comment as done.
frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:823
+static std::pair<SDValue, SDValue>
+getDefaultVLOps(EVT VecVT, EVT ContainerVT, SDLoc DL, SelectionDAG &DAG,
+                const RISCVSubtarget &Subtarget) {
----------------
craig.topper wrote:
> Do these need to be EVT or can they be MVT? May need to use getSimpleValueType in some of the callers.
Thinking again, I don't think they need to be EVTs since these methods should only be used to create legal nodes. Will update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96505/new/

https://reviews.llvm.org/D96505



More information about the llvm-commits mailing list