[PATCH] D96193: [ELF] Rewriting the path of sample profile file for --reproduce response.txt

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In D96193#2558053 <https://reviews.llvm.org/D96193#2558053>, @hoy wrote:

> In D96193#2558021 <https://reviews.llvm.org/D96193#2558021>, @hoy wrote:
>
>> In D96193#2558020 <https://reviews.llvm.org/D96193#2558020>, @thakis wrote:
>>
>>> The extraction seems to makes this test fail on Windows: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8855568452346719664/+/steps/package_clang/0/stdout?format=raw
>>>
>>> Not quite clear why. Maybe path name lengths or something. Can you take a look, and revert for now if it takes a while to fix?
>>
>> Thanks for reporting this issue. I'll make the test limited to Linux only.
>
> So it looks like `tar -xvf` doesn't work on Windows:
>
>   tar: Record size = 10 blocks
>   repro1/response.txt
>   repro1/version.txt
>   repro1/C/b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/tools/lld/test/ELF/Output/reproduce-lto.s.tmp.dir/build1/empty_profile.txt
>   tar: repro1/C/b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/tools/lld/test/ELF/Output/reproduce-lto.s.tmp.dir/build1/empty_profile.txt: Could not create file: No such file or directory
>   repro1/C/b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/tools/lld/test/ELF/Output/reproduce-lto.s.tmp.dir/build1/foo.o
>   tar: repro1/C/b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/tools/lld/test/ELF/Output/reproduce-lto.s.tmp.dir/build1/foo.o: Could not create file: No such file or directory
>   tar: Error exit delayed from previous errors
>    
>   note: command had no output on stdout or stderr
>   error: command failed with exit status: 2
>
> I'm not sure how to disable the test on Windows only so I'm undoing the test changes.

Thanks. My guess it's due to path lengths. Since you only need the rsp file for your test, maybe extracting just that single file (`tar xvf foo.tar myfile`) will work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96193/new/

https://reviews.llvm.org/D96193