[PATCH] D96398: [LTO] Perform DSOLocal propagation in combined index

[Wei Wang via Phabricator via llvm-commits]

weiwang added inline comments.


================
Comment at: llvm/lib/IR/ModuleSummaryIndex.cpp:295
   setWithAttributePropagation();
+  setWithDSOLocalPropagation();
   if (llvm::AreStatisticsEnabled())
----------------
tejohnson wrote:
> tejohnson wrote:
> > We could presumably get by with one merged flag. Not sure it is worth it, in case we decide to decouple these at some point...I don't have a strong feeling so up to you.
> Actually, probably best to leave the flags decoupled. In case we eventually want to be able to disable them independently for debugging.
Sure, I'll leave them decoupled. Side question: I see that withAttributePropagation flag is preserved across bitcode file read/write. If the flag is set when index is materialized, does it mean the propagation was done previously on the index? If that's the case, can we skip it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96398/new/

https://reviews.llvm.org/D96398