[PATCH] D96398: [LTO] Perform DSOLocal propagation in combined index
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 11 17:14:52 PST 2021
tejohnson added inline comments.
================
Comment at: llvm/lib/IR/ModuleSummaryIndex.cpp:295
setWithAttributePropagation();
+ setWithDSOLocalPropagation();
if (llvm::AreStatisticsEnabled())
----------------
tejohnson wrote:
> We could presumably get by with one merged flag. Not sure it is worth it, in case we decide to decouple these at some point...I don't have a strong feeling so up to you.
Actually, probably best to leave the flags decoupled. In case we eventually want to be able to disable them independently for debugging.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96398/new/
https://reviews.llvm.org/D96398
More information about the llvm-commits
mailing list