[PATCH] D96559: Support emitting complex expressions that include entry values

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a reviewer: dstenb.
vsk added a comment.

By no effect on clang, do you mean on the debug info for a stage2 clang binary?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:300
+      if (!isIndirect() && !isParameterValue() && !HasComplexExpression &&
+          +DwarfVersion >= 4)
+        emitOp(dwarf::DW_OP_stack_value);
----------------
Stray +?


================
Comment at: llvm/test/DebugInfo/MIR/X86/complex-entryvalue.mir:85
+  bb.0.entry:
+    DBG_VALUE $edi, $noreg, !14, !DIExpression(DW_OP_LLVM_entry_value, 1, DW_OP_lit0, DW_OP_plus), debug-location !15
+    frame-setup PUSH64r killed $rbp, implicit-def $rsp, implicit $rsp
----------------
Interesting, is 1 code for %rdi? That might be worth a note.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96559/new/

https://reviews.llvm.org/D96559