[PATCH] D96554: Store the LocationKind of an entry value buffer independently from the main LocationKind (NFC)

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 11 16:16:04 PST 2021


vsk added a reviewer: dstenb.
vsk added a comment.

I believe we have test coverage for this path via test/DebugInfo/MIR/AArch64/dbgcall-site-indirect-param-with-offset.mir. Do you think we need anything more?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:403
+  LocationKind = SavedLocationKind;
+  IsEmittingEntryValue = true;
   IsEmittingEntryValue = false;
----------------
No need to set IsEmittingEntryValue here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96554/new/

https://reviews.llvm.org/D96554



More information about the llvm-commits mailing list