[PATCH] D95931: [XCOFF] [NFC] make csect properties optional when create a new section
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 11 14:19:27 PST 2021
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/lib/MC/MCContext.cpp:674
+ auto IterBool = XCOFFUniquingMap.insert(std::make_pair(
+ XCOFFSectionKey{Section.str(), (XCOFF::StorageMappingClass)CsectProp.SMC},
+ nullptr));
----------------
This is eventually going to need to handle the case where the section is not a csect, but for this patch, I think it is okay to write it as it all XCOFF sections are csects. The patch that introduces non-csect XCOFF sections will need to do the update to this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95931/new/
https://reviews.llvm.org/D95931
More information about the llvm-commits
mailing list