[PATCH] D96001: [WebAssembly][lld] Preassign table number 0 to indirect function table for MVP inputs

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 11 14:03:23 PST 2021


sbc100 added inline comments.


================
Comment at: lld/wasm/SyntheticSections.cpp:250
+            "table imports.  Suggest recompiling all inputs with "
+            "-mattr=+reference-types.");
+    }
----------------
Can we be more succinct here?    If you feel its is helpful/necessary to convey all this information than perhaps this verbosity is unavoidable.  

Would something shorter such as "object file was not built -mattr=+reference-types enabled.  This is incompatible with the use tables imports in `<other-object-name>`" be enough?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96001/new/

https://reviews.llvm.org/D96001



More information about the llvm-commits mailing list