[PATCH] D96310: [llvm-objcopy] Delete --build-id-link-{dir,input,output}

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 11 12:12:50 PST 2021


MaskRay added a comment.

In D96310#2556172 <https://reviews.llvm.org/D96310#2556172>, @jhenderson wrote:

> In D96310#2554489 <https://reviews.llvm.org/D96310#2554489>, @MaskRay wrote:
>
>> In D96310#2553465 <https://reviews.llvm.org/D96310#2553465>, @jhenderson wrote:
>>
>>> FWIW, I suspect there are many users of LLVM out there who don't monitor llvm-dev, although an email like you sent certainly can't hurt.
>>
>> I think we cannot and should not care about such users.
>
> Really? What about all the people out there who use systems where the LLVM toolchain is the default? Do you really expect every user who downloads and installs LLVM to have to monitor llvm-dev? I would think that llvm-dev is for developers who develop LLVM primarily, not for general day-to-day end users of the tools. For example, I don't pay much attention to the cfe-dev mailing list, yet I use clang in my Linux environment all the time. If an option was removed from clang at some point, and I happened to have been using it, I'd expect this change to at least be documented in the release notes, along with an alternative suggestion to allow me to solve the problem that I wanted to achieve (I'd still be somewhat annoyed that my. All I'm asking for is the workaround to be explained in the release notes or something else that is publicly visible, so that a user who is impacted by this has a clear path forward.

(Does your advice that we could add that simple llvm-nm option and later delete it https://reviews.llvm.org/D83152#2556189 conflict with the opinion here?)

For `--build-id-link-{dir,input,output}`, it is a pretty niche use case. It solved a problem which was traditionally solved, just providing a direct & fancy alternative. We have confidence that it can be unlikely used by dark web users.
For the problem, I could mark the options deprecated and let llvm-objcopy emit warnings - I don't use that because that is unnecessary and just complicates things. Yes, I'll note down the options in the release notes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96310/new/

https://reviews.llvm.org/D96310



More information about the llvm-commits mailing list