[PATCH] D96514: [flang][fir][NFC] Move BoxProcType to TableGen type definition

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Optimizer/Dialect/FIRType.cpp:1392
+      return mlir::success();
+  return mlir::emitError(loc, "invalid type for boxproc") << eleTy << '\n';
+}
----------------
mehdi_amini wrote:
> schweitz wrote:
> > mehdi_amini wrote:
> > > I didn't ask on the previous revision, but do we already have test coverage on all these? The refactoring could be an opportunity to check this if you can :)
> > Still trying to get enough code upstreamed to add the tool to do that. Chicken-and-egg situation.
> I don't understand the chicken and egg? 
> Adding a `fir-opt` tool *first* seems trivial to me, let me send a patch.
We have a `fir-opt` tool ready in `fir-dev`. I can send a patch.  https://reviews.llvm.org/D96535


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96514/new/

https://reviews.llvm.org/D96514