[PATCH] D96218: [RISCV] Change parseVTypeI function

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 11 12:01:32 PST 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1509
+      break;
+    if (!getLexer().is(AsmToken::Comma))
+      goto MatchFail;
----------------
Can this be isNot?


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1574
+MatchFail:
+  while (VTypeIElements.size() > 0)
+    getLexer().UnLex(VTypeIElements.pop_back_val());
----------------
!VTypeIElements.empty()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96218/new/

https://reviews.llvm.org/D96218



More information about the llvm-commits mailing list