[PATCH] D96455: [SampleFDO][NFC] Refactor SampleProfile.cpp
Rong Xu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 11 11:26:11 PST 2021
xur updated this revision to Diff 323097.
xur added a comment.
Integrated Wei's review comment.
I need to include "using llvm" etc in the header file, as the code below is going to refer the symbols in the namespace.
To avoid affecting other headers, I put the code into a llvm namespace scope.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96455/new/
https://reviews.llvm.org/D96455
Files:
llvm/include/llvm/ProfileData/SampleProfileLoaderBaseImpl.h
llvm/include/llvm/ProfileData/SampleProfileLoaderBaseUtil.h
llvm/lib/ProfileData/CMakeLists.txt
llvm/lib/ProfileData/SampleProfileLoaderBaseUtil.cpp
llvm/lib/Transforms/IPO/SampleProfile.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96455.323097.patch
Type: text/x-patch
Size: 92274 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210211/d3f6a6cd/attachment.bin>
More information about the llvm-commits
mailing list