[PATCH] D96290: [tools] UpdateTestPrefix: improved verbosity

Thu Feb 11 09:50:57 PST 2021

mtrofin marked 2 inline comments as done.
mtrofin added inline comments.

================
Comment at: llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/prefix_warning_verbosity_nowarn.ll:5
+; RUN: llc -mtriple=riscv64 -verify-machineinstrs < %s \
+; RUN:   | FileCheck %s -check-prefixes=CHECK,RV64I
+
----------------
spatel wrote:
> mtrofin wrote:
> > spatel wrote:
> > > If we remove "RV64I" here, then the last 2 functions would have no assertions, right? Do we want to issue a warning for that scenario? Right now, it seems to be silent on that case by default.
> > No, the last 2 functions will have the RV32I assertions from the RUN line above.
> Ah, I see. But those functions would have no assertions for the 2nd RUN line. Is there a way to enable warnings for that case?
That'd be outside the scope of this fix - this one just aims to provide the expected behavior that was sometimes working (because it was buggy) pre-e2dc306b1ac71258e6ce40a66e778527f282c355.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96290/new/

https://reviews.llvm.org/D96290