[PATCH] D95094: [ShrinkWrap] Enable Shrinkwrapping on 32 and 64 bit AIX, and 64 bit ELF

[Sean Fertile via Phabricator via llvm-commits]

sfertile added a comment.

I'll need a bit more time to finish going through `ppc-shrink-wrapping.ll` but the patch is looking really good. Thanks for the updates.



================
Comment at: llvm/test/CodeGen/PowerPC/ppc64-sibcall-shrinkwrap.ll:5
 ; RUN: llc -relocation-model=static -verify-machineinstrs < %s -mtriple=powerpc64le-unknown-linux-gnu -disable-ppc-sco=false --enable-shrink-wrap=true | FileCheck %s -check-prefix=CHECK-SCO-ONLY
+; RUN: llc -relocation-model=pic -verify-machineinstrs < %s -mtriple=powerpc64-ibm-aix-xcoff -disable-ppc-sco=false --enable-shrink-wrap=false | FileCheck %s -check-prefix=CHECK-AIX
+; RUN: llc -relocation-model=pic -verify-machineinstrs < %s -mtriple=powerpc64-ibm-aix-xcoff -disable-ppc-sco=false --enable-shrink-wrap=true | FileCheck %s -check-prefix=CHECK-AIX
----------------
This test is about shrink-wrapping in the presence of sibling calls, but for AIX we won't emit sib calls or tail calls.
I suggest having a  single run step for AIX which uses ` -tailcallopt  -disable-ppc-sco=false --enable-shrink-wrap=true` options and checks for the error we emit in the backend. Then when we address tail-calling it will remind us to update this test.


================
Comment at: llvm/test/CodeGen/PowerPC/shrink-wrap.ll:32
 ; Prolog code
-; CHECK:         std 
-; CHECK:         std 
-; CHECK:         std 
-; CHECK:         std 
+; CHECK:         std
+; CHECK:         std
----------------
jsji wrote:
> You can use `<PREFIX>-COUNT-<num>` to match multiple lines with the same pattern over and over again. 
I didn't know we could do this, it really helps the readability of this test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95094/new/

https://reviews.llvm.org/D95094