[PATCH] D96294: [AArch64] Move machine bundle unpacking to PreEmit2 phase.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

This minor reshuffle looks very reasonable to me, but I was wondering about this:

> With the previous position, the machine outliner may outline parts of a bundle, which breaks them up.

I am not that familiar with the instruction bundles, and the MIR langref description is a bit minimal, but was curious and wanted to ask if this is what the outliner should be doing, i.e. breaking up bundles?



================
Comment at: llvm/test/CodeGen/AArch64/rvmarker-pseudo-expansion-and-outlining.mir:21
+---
+# BLR_RVMARKER calls to the same function. Make sure the marker instruction is not outline on its own.
+#
----------------
Nit: outline -> outlined, and > 80 columns?


================
Comment at: llvm/test/CodeGen/AArch64/rvmarker-pseudo-expansion-and-outlining.mir:79
+---
+# BLR_RVMARKER calls to different function. Make sure the marker instruction is not outline on its own.
+#
----------------
Same


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96294/new/

https://reviews.llvm.org/D96294