[PATCH] D93762: SCCP: Refactor SCCPSolver

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 11 07:58:49 PST 2021


fhahn added a comment.

In D93762#2549267 <https://reviews.llvm.org/D93762#2549267>, @sanwou01 wrote:

> This looks good to me. @fhahn are you happy with the suggested approach to tighten up the SCCPSolver class in subsequent patches, when function inlining starts using it?

IMO we should nail down the interface first, rather than starting with exposing/moving everything, to avoid a lot of unnecessary churn.  As it is structured now, it is not easy to see what is really needed for D93838 <https://reviews.llvm.org/D93838>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93762/new/

https://reviews.llvm.org/D93762



More information about the llvm-commits mailing list