[PATCH] D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

Drive by comment,

> Object output will be handled in followup patches.

[...]

> Since I can not get the assembly file been assembled, I verify the debug info by checking the assembly files.

When support for object emission is added, please translate the empty.ll into an object + llvm-dwarfdump test. Testing the assembly output is fine for the short-term, but in the long term it causes a lot of needless test changes. The NVPTX debug-info tests are all assembly output, and they create an extra burden.



================
Comment at: llvm/test/DebugInfo/XCOFF/empty.ll:18
+
+attributes #0 = { noinline nounwind optnone "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="pwr4" "target-features"="-altivec,-bpermd,-crypto,-direct-move,-extdiv,-float128,-htm,-power8-vector,-power9-vector,-spe,-vsx" "unsafe-fp-math"="false" "use-soft-float"="false" }
+
----------------
NB: we usually delete any un-necessary attributes (normally all of them) for debug-info tests, as they're otherwise a needless maintenance burden.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95518/new/

https://reviews.llvm.org/D95518