[PATCH] D95998: [Debug-Info] [NFC] move emit debug line unit length to MCStreamer class

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

In D95998#2550999 <https://reviews.llvm.org/D95998#2550999>, @ikudrin wrote:

> There is no need to create a new `MCStreamer::emitDwarfLineUnitLength()` method and make all the dependencies public. It is better to just use the already existed `MCStreamer::emitDwarfUnitLength()`. All you need to do is to create a temporary symbol and emit it right after calling `emitDwarfUnitLength()`.
>
> By the way, the said `MCStreamer::emitDwarfUnitLength()` can be simplified so that it is called only with the `Hi` argument, without `Lo`. All the call sites create a temporary symbol, pass it to the method, and emitted it after that. All that can be done inside the method so that the calling code will be simplified. Your other patches in the set will also benefit from that change.

Thanks, I added a `FIXME` in `MCStreamer::emitDwarfLineUnitLength()` to plan to implement `emitDwarfLineUnitLength` in `emitDwarfUnitLength`.
I will try to implement this as you said.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95998/new/

https://reviews.llvm.org/D95998