[PATCH] D90948: [WebAssembly] call_indirect issues table number relocs

[Andy Wingo via Phabricator via llvm-commits]

wingo added a comment.

Thanks for patience with the delay here.  Paging this back in -- I will move the logic from `MC/WasmObjectWriter.cpp` to `WebAssemblyAsmPrinter.cpp` -- there I will iterate over all functions in the module, and if any of them `hasAddressTaken`, then I will ensure an `__indirect_function_table` definition exists and will be written to the output (setNoStrip).  We keep the hack that table symbols only go to the symbol table if they are marked as used in relocations.  If the reference types feature is enabled and an address-taken function is present in the module, the indirect function table will be explicitly marked `isUsedInReloc`.  Just broadcasting intention here so that there are no more late surprises :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90948/new/

https://reviews.llvm.org/D90948