[PATCH] D94013: [libclc] Add clspv target for libclc

Thu Feb 11 06:02:43 PST 2021

alan-baker added a comment.

In D94013#2556056 <https://reviews.llvm.org/D94013#2556056>, @jvesely wrote:

> It'd be nice to add an explanation why this can't reuse the existing SPIR-V targets and needs to add a new one.
> Does the new FMA implementation generate significantly worse code (EG/NI + mesa-spirv should be the only users) than the original? Should it just be replaced? I assume it passes the conformance suite.

The FMA does pass conformance. I don't have performance numbers for the 64-bit version vs the uint2 version. It would be worse, but the whole  software FMA is already awful performance. The 64-bit version is simpler to understand, so unless you have the same restrictions as I need for clspv, then I wouldn't adopt it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94013/new/

https://reviews.llvm.org/D94013