[PATCH] D94677: [lld][WebAssembly] Common superclass for input globals/events/tables

[Andy Wingo via Phabricator via llvm-commits]

wingo added inline comments.


================
Comment at: lld/wasm/InputDefinition.h:25
+protected:
+  explicit InputDefinition(StringRef name, ObjFile *f)
+      : file(f), live(!config->gcSections), name(name) {}
----------------
sbc100 wrote:
> Is the explicit keyword useful here?  I'm used to seeing it mostly on single-arg constructors.
Aah good catch; fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94677/new/

https://reviews.llvm.org/D94677