[PATCH] D96174: [SelectionDAG][AArch64] Restrict matchUnaryPredicate to only handle SPLAT_VECTOR for scalable vectors.

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

Hi, yeah I agree with @frasercrmck here. The only reason I brought this up originally is because callers of the function do something like this:

  if (VT.isFixedLengthVector()) {
  ... Do something with BUILD_VECTOR ...
  } else if (VT.isScalableVector()) {
  .. Do something with SPLAT_VECTOR ...
  }

It felt like since we're already doing this an alternative solution might be to check the opcode instead of the vector type. The patch you have right now does work and wouldn't want to hold it up the patch if you don't have time to fix it right now. It was just a suggestion for another way of dealing with the problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96174/new/

https://reviews.llvm.org/D96174