[PATCH] D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu

[Adhemerval Zanella via Phabricator via llvm-commits]

zatrazz added inline comments.


================
Comment at: compiler-rt/test/sanitizer_common/CMakeLists.txt:82
+    # required to get a complete stacktrace.
+    if (${arch} MATCHES "armhf|arm" AND NOT ANDROID AND NOT WINDOWS AND NOT APPLE)
+      list(APPEND SANITIZER_COMMON_TEST_TARGET_CFLAGS -funwind-tables)
----------------
ostannard wrote:
> Testing for Linux using `NOT ANDROID AND NOT WINDOWS AND NOT APPLE` will break if more operating systems are added in future, and it's not obvious to me that this list is complete now. This is tested with `if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux")` elsewhere in compiler-rt, which looks like a better way to do this.
Right, although this is not strickly required for Android (since it uses clang as base compiler and fast-unwinder works as expected). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96337/new/

https://reviews.llvm.org/D96337