[debuginfo-tests] a31eae8 - [test][Dexter] Fix test failure if space in python path

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 11 03:46:52 PST 2021


Author: James Henderson
Date: 2021-02-11T11:46:39Z
New Revision: a31eae840525e9292a3a42c1fdac3fc594f42949

URL: https://github.com/llvm/llvm-project/commit/a31eae840525e9292a3a42c1fdac3fc594f42949
DIFF: https://github.com/llvm/llvm-project/commit/a31eae840525e9292a3a42c1fdac3fc594f42949.diff

LOG: [test][Dexter] Fix test failure if space in python path

The '%dexter_regression_test' substitution was missing quotes around the
python executable, unlike other substitutions of a similar nature in the
file. This changes fixes the issue.

Differential Revision: https://reviews.llvm.org/D96420

Reviewed by: jmorse, aganea

Added: 
    

Modified: 
    debuginfo-tests/lit.cfg.py

Removed: 
    


################################################################################
diff  --git a/debuginfo-tests/lit.cfg.py b/debuginfo-tests/lit.cfg.py
index 0e436506a96b..bcf31c9d4b8d 100644
--- a/debuginfo-tests/lit.cfg.py
+++ b/debuginfo-tests/lit.cfg.py
@@ -130,8 +130,8 @@ def get_required_attr(config, attr_name):
 # ./path_to_py/python.exe ./path_to_dex/dexter.py test --fail-lt 1.0 -w --builder clang --debugger lldb --cflags '-O0 -g'
 dexter_regression_test_command = ' '.join(
   # "python3", "dexter.py", test, fail_mode, builder, debugger, cflags, ldflags
-  ["{}".format(config.python3_executable),
-  "{}".format(dexter_path),
+  ['"{}"'.format(config.python3_executable),
+  '"{}"'.format(dexter_path),
   'test',
   '--fail-lt 1.0 -w',
   dexter_regression_test_builder,


        


More information about the llvm-commits mailing list