[PATCH] D96470: AMDGPU: Restrict soft clause bundling at half of the available regs
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 10 17:00:49 PST 2021
rampitec added a comment.
I agree RPT needs improvements around tuples, so the w/a seems reasonable for now. I am concerned about huge tests though.
================
Comment at: llvm/test/CodeGen/AMDGPU/limit-soft-clause-reg-pressure.mir:1
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx906 -mattr=+xnack -run-pass=si-form-memory-clauses -verify-machineinstrs -o - %s | FileCheck %s
----------------
Do you really need a test so huge? We will regenerate it very often. At the very least you could just check something small, you only need to make sure it compiles.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96470/new/
https://reviews.llvm.org/D96470
More information about the llvm-commits
mailing list