[PATCH] D96462: [LV] Add remarks that explicitly mention error handling in candidate loops

[Joseph Huber via Phabricator via llvm-commits]

jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, fhahn, SjoerdMeijer.
jhuber6 added a project: LLVM.
Herald added subscribers: ormris, hiraditya.
jhuber6 requested review of this revision.
Herald added a subscriber: llvm-commits.

Some loops contain assertions or other methods of error handling that the user might not be aware of. For example, if the access operator for a custom matrix class had bounds checking. The vectorizer's remarks should be more specific if a loop was not deemed legal for this reason. This patch adds a remark that specifically mentions how to prevent assertions from preventing vectorization, and a more generic response for any control flow that will not return.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96462

Files:
  llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp
  llvm/test/Transforms/LoopVectorize/error-handling-remarks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96462.322850.patch
Type: text/x-patch
Size: 10005 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210211/9fbd93f2/attachment.bin>