[PATCH] D96434: [CSSPGO][llvm-profgen] Filter out the instructions without location info for symbolizer
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 10 15:42:20 PST 2021
hoy added inline comments.
================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:60
uint64_t PrevIP = IP.Address;
- IP.backward();
+ HasNext = IP.backward();
// Break into segments for implicit call/return due to inlining
----------------
wenlei wrote:
> Since all code addresses for the entire binary is record in a single vector, this `HasNext` check is only going to help for the first/last instruction of the entire binary.
>
> Is the problem you're seeing very specific to first/last instruction of the entire binary? I thought instruction without location could happen anywhere..
Yeah, empty inline context should not be uncommon. Is the case where `IP.backward()` resulted in an invalid IP that crashed the `inlineContextEqual` check?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96434/new/
https://reviews.llvm.org/D96434
More information about the llvm-commits
mailing list