[PATCH] D96422: [flang][fir][NFC] Move ShapeType to TableGen type definition

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 15:06:02 PST 2021


clementval marked an inline comment as done.
clementval added inline comments.


================
Comment at: flang/include/flang/Optimizer/Dialect/FIRTypes.td:46
+    if ($_parser.parseGreater())
+      return Type();
+    return get(context, rank);
----------------
mehdi_amini wrote:
> Parser methods are usually chained like this:
> 
> ```
>   int rank;
>   if ($_parser.parseLess() || $_parser.parseInteger(rank) || $_parser.parseGreater())
>       return Type();
> ```
Sure it looks cleaner. I just updated the patch before landing it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96422/new/

https://reviews.llvm.org/D96422



More information about the llvm-commits mailing list