[PATCH] D96422: [flang][fir][NFC] Move ShapeType to TableGen type definition

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 13:55:36 PST 2021


mehdi_amini accepted this revision.
mehdi_amini added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/include/flang/Optimizer/Dialect/FIRTypes.td:46
+    if ($_parser.parseGreater())
+      return Type();
+    return get(context, rank);
----------------
Parser methods are usually chained like this:

```
  int rank;
  if ($_parser.parseLess() || $_parser.parseInteger(rank) || $_parser.parseGreater())
      return Type();
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96422/new/

https://reviews.llvm.org/D96422



More information about the llvm-commits mailing list