[PATCH] D96362: [flang][fir] Update the kind mapping class.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: flang/lib/Optimizer/Support/KindMapping.cpp:194
   if (mlir::failed(parse(map))) {
+    mlir::emitError(mlir::UnknownLoc::get(context), "could not parse kind map");
     intMap.clear();
----------------
schweitz wrote:
> mehdi_amini wrote:
> > Seems like the constructor can fail here, should this be a factory function returning an optional then?
> > Otherwise the caller can't really know...
> Failure here is catastrophic. I'll change this to an error message with abort semantics.
LG!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96362/new/

https://reviews.llvm.org/D96362