[PATCH] D96446: [flang][fir][NFC] Move CharacterType and BoxCharType to to TableGen type definition

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 12:40:24 PST 2021


clementval added inline comments.


================
Comment at: flang/include/flang/Optimizer/Dialect/FIRTypes.td:51
 
+def A_CharacterType : FIR_Type<"Character", "char"> {
+  let summary = "FIR character type";
----------------
@mehdi_amini @rriddle I'm currently forcing this type to be generated before BoxCharType because it depends on it. Is there a better way to achieve this than adding a prefix (`A_`)? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96446/new/

https://reviews.llvm.org/D96446



More information about the llvm-commits mailing list