[PATCH] D96289: Add support for YAML output style to llvm-symbolizer

[Alex Orlov via Phabricator via llvm-commits]

aorlov updated this revision to Diff 322788.
aorlov added a comment.
Herald added a reviewer: jdoerfert.
Herald added subscribers: sstefan1, ormris.

I have updated the patch. It

- addresses the review comments,
- adds more tests for YAML output style similar to the existing tests we have for other output styles. In particular output-style-yaml-data.test is based on untag-addresses.test, output-style-yaml-frame.test is based on frame-types.s.
- updates llvm-symbolizer documentation.

Unless I’m missing something, addr2line documentation is not affected, as it just provides a reference to the llvm-symbolizer doc, which is changed by this patch.

By the way, while looking at the addr2line documentation, I have noticed that the documentation does not match the code. In particular, -f flag is ignored for llvm-adr2line. This issue is out of the scope of this patch, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96289/new/

https://reviews.llvm.org/D96289

Files:
  llvm/docs/CommandGuide/llvm-symbolizer.rst
  llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
  llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
  llvm/test/tools/llvm-symbolizer/output-style-yaml-data.test
  llvm/test/tools/llvm-symbolizer/output-style-yaml-frame.test
  llvm/test/tools/llvm-symbolizer/output-style-yaml.test
  llvm/tools/llvm-symbolizer/Opts.td
  llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96289.322788.patch
Type: text/x-patch
Size: 36656 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210210/23ecc622/attachment.bin>