[PATCH] D95807: [RFC][Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

Wed Feb 10 11:58:56 PST 2021

lxfind added a comment.

In D95807#2538160 <https://reviews.llvm.org/D95807#2538160>, @ChuanqiXu wrote:

> In D95807#2537105 <https://reviews.llvm.org/D95807#2537105>, @lxfind wrote:
>
>> By the way, is everyone comfortable with dropping the test lines using the legacy pass manager for Coroutine? 
>> It's really painful to update the tests to keep both legacy pass manager and new pass manager, now that the pass sequence becomes much different. (CoroSplit runs late in CGSCC pipeline for NewPM, but early in legacy pm).
>> If we want to keep the legacy PM tests for a while for coroutine, I could wait until everyone is comfortable before updating this patch again.
>
> I think testing is more important than the develop experience. It is more suitable to remove the tests for legacy pass manager when the old pass manager got replaced entirely.

By the way, since the new PM has been enabled by default, all of the tests are no longer testing Legacy PM behavior anymore (unless explicitly specified --enable-new-pm=0)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95807/new/

https://reviews.llvm.org/D95807