[PATCH] D94013: [libclc] Add clspv target for libclc

[Tom Stellard via Phabricator via llvm-commits]

tstellar added inline comments.


================
Comment at: libclc/CMakeLists.txt:239
 	# the one listed in SOURCES
-	if( NOT ${ARCH} STREQUAL "spirv" AND NOT ${ARCH} STREQUAL "spirv64" )
+  if( NOT ${ARCH} STREQUAL "spirv" AND NOT ${ARCH} STREQUAL "spirv64" )
 		set( rel_files convert.cl )
----------------
This looks like more whitespace changes.


================
Comment at: libclc/generic/lib/gen_convert.py:358
     print("  {DST}{N} r = convert_{DST}{N}(x);".format(DST=dst, N=size))
-    print("  {SRC}{N} y = convert_{SRC}{N}(y);".format(SRC=src, N=size))
+    print("  {SRC}{N} y = convert_{SRC}{N}(r);".format(SRC=src, N=size))
     if mode == '_rtz':
----------------
Why did this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94013/new/

https://reviews.llvm.org/D94013