[llvm] 997f6b6 - [CMake] Remove some dead code in llvm_install_library_symlink()

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 10:13:37 PST 2021


Author: Tom Stellard
Date: 2021-02-10T10:13:04-08:00
New Revision: 997f6b6f8e06b75f57041518440a8393e17713c0

URL: https://github.com/llvm/llvm-project/commit/997f6b6f8e06b75f57041518440a8393e17713c0
DIFF: https://github.com/llvm/llvm-project/commit/997f6b6f8e06b75f57041518440a8393e17713c0.diff

LOG: [CMake] Remove some dead code in llvm_install_library_symlink()

Reviewed By: smeenai

Differential Revision: https://reviews.llvm.org/D95666

Added: 
    

Modified: 
    llvm/cmake/modules/AddLLVM.cmake

Removed: 
    


################################################################################
diff  --git a/llvm/cmake/modules/AddLLVM.cmake b/llvm/cmake/modules/AddLLVM.cmake
index 97c9980c7de3..09de62ac3f55 100644
--- a/llvm/cmake/modules/AddLLVM.cmake
+++ b/llvm/cmake/modules/AddLLVM.cmake
@@ -595,11 +595,9 @@ function(llvm_add_library name)
       set(api_name ${output_name}-${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX})
       set_target_properties(${name} PROPERTIES OUTPUT_NAME ${library_name})
       llvm_install_library_symlink(${api_name} ${library_name} SHARED
-        COMPONENT ${name}
-        ALWAYS_GENERATE)
+        COMPONENT ${name})
       llvm_install_library_symlink(${output_name} ${library_name} SHARED
-        COMPONENT ${name}
-        ALWAYS_GENERATE)
+        COMPONENT ${name})
     endif()
   endif()
 
@@ -1838,7 +1836,7 @@ function(add_lit_testsuites project directory)
 endfunction()
 
 function(llvm_install_library_symlink name dest type)
-  cmake_parse_arguments(ARG "ALWAYS_GENERATE" "COMPONENT" "" ${ARGN})
+  cmake_parse_arguments(ARG "" "COMPONENT" "" ${ARGN})
   foreach(path ${CMAKE_MODULE_PATH})
     if(EXISTS ${path}/LLVMInstallSymlink.cmake)
       set(INSTALL_SYMLINK ${path}/LLVMInstallSymlink.cmake)
@@ -1863,12 +1861,6 @@ function(llvm_install_library_symlink name dest type)
           CODE "install_symlink(${full_name} ${full_dest} ${output_dir})"
           COMPONENT ${component})
 
-  if (NOT LLVM_ENABLE_IDE AND NOT ARG_ALWAYS_GENERATE)
-    add_llvm_install_targets(install-${name}
-                             DEPENDS ${name} ${dest}
-                             COMPONENT ${name}
-                             SYMLINK ${dest})
-  endif()
 endfunction()
 
 function(llvm_install_symlink name dest)


        


More information about the llvm-commits mailing list