[PATCH] D96371: [lit] Add --ignore-fail

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D96371#2554143 <https://reviews.llvm.org/D96371#2554143>, @jdenny wrote:

> In D96371#2553434 <https://reviews.llvm.org/D96371#2553434>, @jhenderson wrote:
>
>> Personally, I think it should be the default to run all testsuites rather than exiting after the first failure. The exit code should then be the combined one, i.e. whether any of the suites has failed.
>>
>> Is it not possible to pass the exit code up the stack rather than `sys.exit(1)` there? The caller (llvm-lit.py?) of the multiple suites would then be responsible for checking all `main()` calls passed.
>
> The caller of lit each time is ninja/make.  To fix this case, cmake files would likely be redesigned so that lit is called once for all suites together.  Surely that's technically possible, and I agree it would be better than using `--ignore-fail`.
>
> However, I argue that this isn't the first time I've seen check-all call lit multiple times, and I'm assuming it will happen again even if this case is fixed.  This patch provides an easy workaround every time, and it has a small footprint within lit.

Surely you can ignore the error code in the lit caller one way or another?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96371/new/

https://reviews.llvm.org/D96371