[PATCH] D96411: [flang] Remove `LINK_WITH_FIR` cmake switch

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 09:03:50 PST 2021


SouraVX added inline comments.


================
Comment at: flang/CMakeLists.txt:216
+set(LLVM_BUILD_TOOLS ON)
+set(LLVM_COMMON_COMPONENTS Support)
+message(STATUS "Linking driver with FIR and LLVM, using LLVM components: ${LLVM_COMMON_COMPONENTS}")
----------------
tskeith wrote:
> Is this used?
Seems like not needed.


================
Comment at: flang/CMakeLists.txt:217
+set(LLVM_COMMON_COMPONENTS Support)
+message(STATUS "Linking driver with FIR and LLVM, using LLVM components: ${LLVM_COMMON_COMPONENTS}")
 
----------------
tskeith wrote:
> I don't think this message is needed any more.
Removed thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96411/new/

https://reviews.llvm.org/D96411



More information about the llvm-commits mailing list