[PATCH] D96420: [test][Dexter] Fix test failure if space in python path

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 07:20:36 PST 2021


jhenderson created this revision.
jhenderson added reviewers: aganea, jmorse, Orlando, rnk, dblaikie.
jhenderson requested review of this revision.
Herald added a project: LLVM.

The '%dexter_regression_test' substitution was missing quotes around the python executable, unlike other substitutions of a similar nature in the file. This changes fixes the issue.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96420

Files:
  debuginfo-tests/lit.cfg.py


Index: debuginfo-tests/lit.cfg.py
===================================================================
--- debuginfo-tests/lit.cfg.py
+++ debuginfo-tests/lit.cfg.py
@@ -130,8 +130,8 @@
 # ./path_to_py/python.exe ./path_to_dex/dexter.py test --fail-lt 1.0 -w --builder clang --debugger lldb --cflags '-O0 -g'
 dexter_regression_test_command = ' '.join(
   # "python3", "dexter.py", test, fail_mode, builder, debugger, cflags, ldflags
-  ["{}".format(config.python3_executable),
-  "{}".format(dexter_path),
+  ['"{}"'.format(config.python3_executable),
+  '"{}"'.format(dexter_path),
   'test',
   '--fail-lt 1.0 -w',
   dexter_regression_test_builder,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96420.322676.patch
Type: text/x-patch
Size: 651 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210210/2cd5c55b/attachment.bin>


More information about the llvm-commits mailing list