[PATCH] D96020: [TTI] Change TargetTransformInfo::getMinimumVF to return ElementCount

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 05:12:40 PST 2021


c-rhodes added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:949
+  /// If IsScalableVF is true, the returned ElementCount must be a scalable VF.
+  ElementCount getMinimumVF(unsigned ElemWidth, bool IsScalableVF) const;
 
----------------
nit: drop `VF` from operand? Personally I don't think it adds much


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5815
     }
-    if (auto MinVF = ElementCount::getFixed(TTI.getMinimumVF(SmallestType))) {
+    if (ElementCount MinVF = TTI.getMinimumVF(SmallestType, false)) {
       if (ElementCount::isKnownLT(MaxVF, MinVF)) {
----------------
`/*IsScalableVF=*/false`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96020/new/

https://reviews.llvm.org/D96020



More information about the llvm-commits mailing list