[PATCH] D96309: [AMDGPU] Refactor MIMG tables to better handle hardware variants

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/MIMGInstructions.td:835
+defm IMAGE_ATOMIC_SUB           : MIMG_Atomic <mimgopc<0x12, 0x13, 0x12>, "image_atomic_sub">;
+defm IMAGE_ATOMIC_RSUB          : MIMG_Atomic <mimgopc<MIMG.NOP, MIMG.NOP, 0x13>, "image_atomic_rsub">;
+defm IMAGE_ATOMIC_SMIN          : MIMG_Atomic <mimgopc<0x14>, "image_atomic_smin">;
----------------
critson wrote:
> foad wrote:
> > Needs asm/dis tests?
> I have added asm tests.
> There are no disassembly tests for GFX7, and I do not think this is the right time to add them.
Sure. You would have to add a gfx7 disassembler first :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96309/new/

https://reviews.llvm.org/D96309