[PATCH] D96310: [llvm-objcopy] Delete --build-id-link-{dir,input,output}

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

FWIW, I suspect there are many users of LLVM out there who don't monitor llvm-dev, although an email like you sent certainly can't hurt.

If the workaround is spelt out for people, I'm not opposed, as already mentioned.



================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.h:446
 
+  ArrayRef<uint8_t> Contents;
+
----------------
MaskRay wrote:
> jhenderson wrote:
> > This change seems unrelated?
> This is natural after the last public user of Contents is deleted.
> 
> It does not seem necessary to defer it to a subsequent clean-up.
I'd agree with that, except I can't see where Contents was previously being used?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96310/new/

https://reviews.llvm.org/D96310