[PATCH] D83152: llvm-nm: add flag to suppress no symbols warning

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D83152#2553151 <https://reviews.llvm.org/D83152#2553151>, @keith wrote:

>> I think it is case by case. For this one, `2> /dev/null` is a simple and easy workaround. I find it difficult to argue against this choice. There was an equally good suggestion `--quiet` we cannot refute.
>
> I disagree that this is a viable workaround since nm produces quite a few more errors that you likely don't want to filter out

+1 to this - in fact, I already pointed this out further up in the comments.

I am strongly opposed to us having to get buy-in from GNU binutils to be able to add new options - I don't think has ever been agreed upon widely. Requiring this coordination stifles addition of new features in our toolchain. Over the years, we have added many options and features to the LLVM binutils that diverge from what GNU have done. As long as they don't clash, and have a valid use case, I don't think this is a bad thing - if GNU developers want to later implement it themselves, there's nothing stopping them, but I don't think we should be forced into coordination on it. The one thing I would say is that we should avoid using option names that have the potential to clash, for example single character aliases, unless there's some coordination.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83152/new/

https://reviews.llvm.org/D83152