[PATCH] D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase

Tue Feb 9 22:13:43 PST 2021

TaoPan added a comment.

In D96393#2553156 <https://reviews.llvm.org/D96393#2553156>, @snehasish wrote:

> Can you elaborate on the motivation behind this test?
>
> As the behaviour exists today, -split-machine-functions and -basic-block-sections are exclusive options and the former takes precedence. With D96392 <https://reviews.llvm.org/D96392> we are planning on switching the precedence but they still remain exclusive. Thus in this test, the RUN invocations on line 2,3 and 4 are using -split-machine-functions. Furthermore, the underlying mechanism driving both options are the same so testing the generation of debug information together is redundant. For more information take a look at the discussion in D90989 <https://reviews.llvm.org/D90989>.

Thanks for your review comment! I got the current exclusive relation, and -basic-block-section will take precedence over -split-machine-functions after D96392 <https://reviews.llvm.org/D96392> is done.
I added motivation to Summary, removed redundant test related to -basic-block-sections.
Could you please have a look?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96393/new/

https://reviews.llvm.org/D96393