[PATCH] D96184: [AIX][TLS] Generate TLS variables in assembly files

[David Tenty via Phabricator via llvm-commits]

daltenty requested changes to this revision.
daltenty added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-tls-variables.ll:21
+; CHECK-NEXT: .vbyte	4, 1
+; CHECK-NEXT: .csect glo2[RW],2
+; CHECK-NEXT: .globl	glo2[RW]
----------------
daltenty wrote:
> It's out of scope for this patch, but there is definitely a delta here between how we emit thread-local (to .tbss) and non-thread local uninitialized data (i.e. to regular data section instead of bss) beyond just the thread-local part. Not sure if that's something we should address.
As a follow on, as discussed offline, using common for uninitialized data may have linkage considerations. We should consider if this applies to `.tbss` data as well before using `.comm` directives.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96184/new/

https://reviews.llvm.org/D96184