[PATCH] D96392: [CodeGen] Basic block sections should take precendence over splitting.

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1190
   // Machine function splitter uses the basic block sections feature. Both
-  // cannot be enabled at the same time.
-  if (TM->Options.EnableMachineFunctionSplitter ||
-      EnableMachineFunctionSplitter) {
-    addPass(createMachineFunctionSplitterPass());
-  } else if (TM->getBBSectionsType() != llvm::BasicBlockSection::None) {
+  // cannot be enabled at the same time. Basic block sections takes precedence.
+  if (TM->getBBSectionsType() != llvm::BasicBlockSection::None) {
----------------
Could you add a TODO here that Machine Function Splitting and Basic Block Labels are in principle fine together but we have not addressed it yet?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96392/new/

https://reviews.llvm.org/D96392