[PATCH] D95960: [llvm][IR] Do not place constants with static relocations in a mergeable section

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 18:10:46 PST 2021


pcc added a comment.

I don't think we want 3 functions here because the distinction between your `needsDynamicRelocation` and `needsRelocation` isn't meaningful (a dynamic relocation can always be relaxed to a static one by the linker). There should probably just be `needsRelocation()` (needs static or dynamic) and `needsDynamicRelocation()` (needs dynamic).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95960/new/

https://reviews.llvm.org/D95960



More information about the llvm-commits mailing list