[PATCH] D96352: [RISCV] Initial support for insert/extract subvector

ShihPo Hung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 16:25:27 PST 2021


arcbbb marked 4 inline comments as done.
arcbbb added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:38
+
+  unsigned LMul = Subtarget->getLMULForFixedLengthVector(VT);
+  unsigned RCID;
----------------
craig.topper wrote:
> Would it be simpler to get the LMUL from the size of the fixed part of the scalable type? We don't need subtarget for that.
I was considering it was possible to insert/extract an M1 fixed-width vector into/from an M2 scalable vector, so I get the LMUL from the fixed-width one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96352/new/

https://reviews.llvm.org/D96352



More information about the llvm-commits mailing list