[PATCH] D79023: [mlir][vector] let transfer_read and transfer_write take non-zero addrspace.

Andrew Pritchard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 15:12:48 PST 2021


awpr added a comment.
Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, stephenneuendorffer.

Is it important for the memory accesses here to be done via addrspace 0, or is that just an artifact of making the pointer type match up?  It seems that for many architectures with multiple memory spaces, it won't be possible to address all memory via addrspace 0, and memory accesses should be done in the addrspace their memref lives in; but I'm not sure whether making that change would affect the use case this was meant for.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79023/new/

https://reviews.llvm.org/D79023



More information about the llvm-commits mailing list