[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

[Ana Pazos via Phabricator via llvm-commits]

apazos added inline comments.


================
Comment at: clang/test/CodeGen/aarch64-neon-sm4-sm3-invalid.c:8
+
+void test_range_check_vsm3tt1a(uint32x4_t a, uint32x4_t b, uint32x4_t c) {
+  // CHECK-RANGE: error: argument value 5 is outside the valid range [0, 3]
----------------
Consider renaming the test with range-check suffix so it is clear it is checking for invalid  range for the immediate
In addition, consider rewriting it with //expected-error checks


================
Comment at: clang/test/CodeGen/aarch64-neon-sm4-sm3.c:5
+
+// RUN: not %clang_cc1 -triple aarch64-linux-gnu -target-feature +neon \
+// RUN: -S -emit-llvm -o - %s 2>&1 | FileCheck --check-prefix=CHECK-NO-CRYPTO %s
----------------
The test is written for aarch64 triple, in addition @t.p.northover might want to add arm64 triple checks. Tim what do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95655/new/

https://reviews.llvm.org/D95655